Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix (proxy): fix for float quant properties is_ocp and is_fnuz #1028

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix (proxy): fix for float quant properties is_ocp and is_fnuz #1028

merged 1 commit into from
Oct 8, 2024

Conversation

alexredd99
Copy link
Contributor

Fixes issue #1027 and float quant proxies now check that mantissa_bit_width = 2 and exponent_bit_width = 5 when determining if an FP8E5M2 minifloat is OCP or FNUZ.

@alexredd99
Copy link
Contributor Author

Should we add tests for these properties? If so, where would be a good place to add them?

@Giuseppe5
Copy link
Collaborator

We could add them with the export tests in ORT since these properties are mostly useful for that

@Giuseppe5
Copy link
Collaborator

Thanks for spotting and fixing!

@nickfraser nickfraser added the next release PRs which should be merged for the next release label Oct 8, 2024
@Giuseppe5 Giuseppe5 merged commit 0b18761 into Xilinx:dev Oct 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
next release PRs which should be merged for the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexredd99 @Giuseppe5 @nickfraser