Workaround to limit Aperture Size Limit as part of QDMA Queues for SOFT QDMA IP. #7979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DMG Karthik <[email protected]>
Signed-off-by: DMG Karthik <[email protected]>
Signed-off-by: DMG Karthik <[email protected]>
Signed-off-by: DMG Karthik <[email protected]>
chvamshi-xilinx
approved these changes
Mar 5, 2024
| @@ -541,6 +555,11 @@ static int set_max_chan(struct xocl_qdma *qdma, u32 count) | |||
| qconf->qidx = qidx; | |||
| qconf->irq_en = (qdma->dev_conf.qdma_drv_mode == POLL_MODE) ? | |||
| 0 : 1; | |||
| if (is_soft_qdma) | |||
| { | |||
There was a problem hiding this comment.
Please use "{" along with if condition in next PR
karthdmg-xilinx
added a commit
to karthdmg-xilinx/XRT
that referenced
this pull request
May 28, 2024
…s for SOFT QDMA IP. (Xilinx#7979)" Reverting the changes since the work around has been handled as part of QDMA driver. This reverts commit cc30690.
chvamshi-xilinx
pushed a commit
that referenced
this pull request
May 28, 2024
* Revert "Workaround to limit Aperture Size Limit as part of QDMA Queues for SOFT QDMA IP. (#7979)" Reverting the changes since the work around has been handled as part of QDMA driver. This reverts commit cc30690. * reverting QDMA changes in XRT Signed-off-by: Karthik DMG <[email protected]> --------- Signed-off-by: Karthik DMG <[email protected]>
karthdmg-xilinx
added a commit
to karthdmg-xilinx/XRT
that referenced
this pull request
Jun 4, 2024
* Revert "Workaround to limit Aperture Size Limit as part of QDMA Queues for SOFT QDMA IP. (Xilinx#7979)" Reverting the changes since the work around has been handled as part of QDMA driver. This reverts commit cc30690. * reverting QDMA changes in XRT Signed-off-by: Karthik DMG <[email protected]> --------- Signed-off-by: Karthik DMG <[email protected]> (cherry picked from commit 4cb2c5d)
chvamshi-xilinx
pushed a commit
that referenced
this pull request
Jun 5, 2024
* Revert "Workaround to limit Aperture Size Limit as part of QDMA Queues for SOFT QDMA IP. (#7979)" Reverting the changes since the work around has been handled as part of QDMA driver. This reverts commit cc30690. * reverting QDMA changes in XRT Signed-off-by: Karthik DMG <[email protected]> --------- Signed-off-by: Karthik DMG <[email protected]> (cherry picked from commit 4cb2c5d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
The SOFT IP on RAVE Platform is unable to handle DMA requests if the block size exceeds 64k.
HW team is working towards the fix in IP.
Adding a temporary WA as part of XRT QDMA subdev until we have a fix in SOFT IP.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
The SOFT IP on RAVE Platform is unable to handle DMA requests if the block size exceeds 64k.
How problem was solved, alternative solutions (if any) and why they were rejected
Added a temporary WA as part of XRT QDMA subdev until we have a fix in SOFT IP.
Risks (if any) associated the changes in the commit
NA
What has been tested and how, request additional testing if necessary
-Tested the aperture size is being set to 32k size for SOFT IPs.
Documentation impact (if any)
None.