Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial PLIO support to the platform #13

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Adding initial PLIO support to the platform #13

merged 9 commits into from
Jul 24, 2024

Conversation

eddierichter-amd
Copy link
Collaborator

This is linked to the mlir-aie PR that adds PLIO support to the compiler and has an example that targets this platform.

@stephenneuendorffer
Copy link
Collaborator

Are you really still using 2022.1? updating to 2023.2 would be good, which is where most of the other work is, although I expect we'll move to 2024.2 once it's released.

@eddierichter-amd
Copy link
Collaborator Author

Are you really still using 2022.1? updating to 2023.2 would be good, which is where most of the other work is, although I expect we'll move to 2024.2 once it's released.

It is a good point, I made an issue to track this: #14. Note that this version is solely for building the platform, so this does not preclude using 2023.2 or whatever newer version for mlir-aie (2023.2 is what I currently use), only that you need 2022.1 to build the platform. That being said, I get that now that we are opening up the platform for users to integrate their PL designs it makes sense to update the Vitis version for the platform as well.

Copy link
Collaborator

@muwyse-amd muwyse-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor change

Comment on lines 59 to 65
# Putting where we put the PL source code
PL_SRC_REPO := ./pl
COUNTER_KERNEL_TOP := counter_hls
COUNTER_KERNEL_SRC := $(PL_SRC_REPO)/counter/$(COUNTER_KERNEL_TOP).cpp
COUNTER_KERNEL_XO := $(COUNTER_KERNEL_TOP).$(TARGET)
COUNTER_KERNEL_VPP_FLAGS := --hls.clock $(VPP_CLOCK_FREQ):$(COUNTER_KERNEL_TOP)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use "=" instead of ":="

@eddierichter-amd eddierichter-amd merged commit cd135f2 into main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants