Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataFree overflows int #184

Closed
LiJunWei opened this issue Jan 9, 2019 · 1 comment · Fixed by #186
Closed

DataFree overflows int #184

LiJunWei opened this issue Jan 9, 2019 · 1 comment · Fixed by #186
Labels
bug Something isn't working

Comments

@LiJunWei
Copy link

LiJunWei commented Jan 9, 2019

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.

[E] [show.go:110] recover ShowTableStatus()%!(EXTRA *strconv.NumError=strconv.Atoi: parsing "18446744055523987336": value out of range)

  1. What did you expect to see?
    大表Data_free值特别大超过int类型数值上限的情况可以正常执行

  2. What did you see instead?

  3. What version of are you using (soar -version)?
    0.9.0
@LiJunWei LiJunWei mentioned this issue Jan 9, 2019
Closed
@martianzhang martianzhang added the bug Something isn't working label Jan 10, 2019
@martianzhang
Copy link
Contributor

0.9.0 soar use mymysql, but now(0.10+) soar use go-sql-driver for MySQL driver. strconv.Atoi is not used now.

As #185 mentioned, DataFree's datatype needs to change to uint64, and other table status int type field.

martianzhang added a commit that referenced this issue Jan 10, 2019
@martianzhang
fix #184 table status field datatype overflow
9ae6752 
  SHOW TABLE STATUS

  Rows
  AvgRowLength
  DataLENGTH
  MaxDataLength
  IndexLength
  DataFree
@martianzhang martianzhang mentioned this issue Jan 10, 2019
Merged
xiyangxixian added a commit that referenced this issue Jan 11, 2019
@xiyangxixian
Merge pull request #186 from XiaoMi/dev
7e7eead 
fix #184 and #173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #184 and #173 XiaoMi/soar
2 participants
@martianzhang @LiJunWei