This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
fix(one-time backup): fix bug when backup request is timeout #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: restrict the replication factor while creating app (XiaoMi#963) feat(manual_compaction): meta server support querying compaction status (XiaoMi#987) manual test
levy5307
reviewed
Dec 17, 2021
hycdong
reviewed
Dec 21, 2021
Smityz
force-pushed
the
fix_timeout
branch
2 times, most recently
from
December 21, 2021 03:58
82719f6
to
ed73aba
Compare
hycdong
reviewed
Dec 21, 2021
hycdong
reviewed
Dec 23, 2021
hycdong
previously approved these changes
Dec 24, 2021
Smityz
changed the title
fix(one-time backup): fix bug when request is timeout
fix(one-time backup): fix bug when backup request is timeout
Jan 24, 2022
foreverneverer
previously approved these changes
Jan 26, 2022
hycdong
reviewed
Jan 26, 2022
Smityz
commented
Jan 26, 2022
hycdong
approved these changes
Jan 26, 2022
foreverneverer
approved these changes
Jan 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/incubator-pegasus#893
ref https://github.com/XiaoMi/rdsn/blob/master/src/meta/backup_engine.cpp#L202
If
err
== TIME_OUT,response
will be empty, then coredump.Tests