Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix(one-time backup): fix bug when backup request is timeout #990

Merged
merged 12 commits into from
Jan 26, 2022

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Dec 16, 2021

apache/incubator-pegasus#893

ref https://github.com/XiaoMi/rdsn/blob/master/src/meta/backup_engine.cpp#L202
If err == TIME_OUT, response will be empty, then coredump.

Tests

  • fix the origin unit test
  • manual test in onebox

feat: restrict the replication factor while creating app (XiaoMi#963)

feat(manual_compaction): meta server support querying compaction status (XiaoMi#987)

manual test
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
@Smityz Smityz force-pushed the fix_timeout branch 2 times, most recently from 82719f6 to ed73aba Compare December 21, 2021 03:58
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
src/meta/backup_engine.cpp Show resolved Hide resolved
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
src/meta/backup_engine.cpp Show resolved Hide resolved
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
hycdong
hycdong previously approved these changes Dec 24, 2021
@Smityz Smityz changed the title fix(one-time backup): fix bug when request is timeout fix(one-time backup): fix bug when backup request is timeout Jan 24, 2022
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
src/meta/backup_engine.cpp Show resolved Hide resolved
foreverneverer
foreverneverer previously approved these changes Jan 26, 2022
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
src/meta/backup_engine.cpp Outdated Show resolved Hide resolved
@Smityz Smityz merged commit 96d4409 into XiaoMi:master Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants