Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat: add rate limiter for per disk when nfs copy data #944

Merged
merged 17 commits into from
Oct 27, 2021
Merged

feat: add rate limiter for per disk when nfs copy data #944

merged 17 commits into from
Oct 27, 2021

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Oct 25, 2021 •
edited
Loading

We have add node-level nfs copy limiter: #461 #901, but we found that every disk load need be limited to avoid the large disk load , this pr add rate limiter for per disk when nfs copy data

Config-Change

- max_copy_rate_megabytes = 500
+ max_copy_rate_megabytes_per_disk = 500

- max_send_rate_megabytes = 500
+ max_send_rate_megabytes_per_disk = 500

@foreverneverer foreverneverer added the type/config-change PR that made modification on configs, which should be noted in release note. label Oct 26, 2021
@foreverneverer foreverneverer marked this pull request as ready for review October 26, 2021 02:32
Smityz
Smityz reviewed Oct 27, 2021
View reviewed changes
src/nfs/nfs_server_impl.cpp Outdated Show resolved Hide resolved
Smityz
Smityz reviewed Oct 27, 2021
View reviewed changes
src/nfs/nfs_client_impl.cpp Outdated Show resolved Hide resolved
@levy5307 levy5307 merged commit 1e8b2ba into XiaoMi:master Oct 27, 2021
This was referenced Nov 3, 2021
Merged
Merged
@foreverneverer foreverneverer mentioned this pull request Nov 19, 2021
Open
8 tasks
@foreverneverer foreverneverer mentioned this pull request Jul 6, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Smityz Smityz Smityz left review comments

@levy5307 levy5307 levy5307 approved these changes

@hycdong hycdong hycdong approved these changes

Assignees
No one assigned
Labels
type/config-change PR that made modification on configs, which should be noted in release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foreverneverer @hycdong @levy5307 @Smityz