-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
@@ -114,6 +114,12 @@ class rpc_holder | |||
return _i->thrift_response; | |||
} | |||
|
|||
dsn::error_code &error() const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can add some unit tests for rpc_holder
I suggest splitting this pull request into 3 parts:
Besides, I notice that you implement |
which folder do you suggest? |
I recommend implement common utility under |
The interface refers to https://github.com/XiaoMi/rdsn/blob/master/src/utils/throttling_controller.h |
|
||
if (res.get_value_or(0) > 0) { | ||
if (is_get_perfcounter) { | ||
_reject_task_counter->operator->()->increment(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move _reject_task_counter up to "incubator-pegasus: src/server/pegasus_server_impl.cpp", and increase this counter while return “ERR_BUSY”.
has merged split prs |
Ref: apache/incubator-pegasus#830