-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
src/replica/replica_stub.cpp
Outdated
return msg; | ||
} | ||
|
||
static std::string process_jemalloc_gc_arena_command(const std::vector<std::string> &args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request. And I think you can split it into serveral pull requests, because this patch is too big
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you pull request. And I think you can split it into serveral pull requests, because this patch is too big
Ok, I'll first commit build-related code (e.g. cmake files and build scripts), and the remote_command tools for jemalloc will be provided later.
It's a good idea to support jemalloc! Could you show the performance test between tcmalloc(default choice) and jemalloc? |
Sure, I'll give the performance comparison as we've showed at the meetup. |
Good job! Thank you empiredan! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request again! Looking forward to your next work
It's well known that jemalloc is an excellent memory allocator, especially scalable for multi-threaded applications. It's adopted or supported by many famous projects, such as redis, clickhouse, rocksdb, etc.
By this PR, developer can choose to use jemalloc as the allocator of rDSN (default allocator/profiler is still tcmalloc/gperftools). Once chosen, rDSN can be compiled and linked with jemalloc dynamically or statically.
apache/incubator-pegasus#913