This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: add function to get cluster migration info #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
approved these changes
Jul 30, 2021
Smityz
approved these changes
Aug 2, 2021
| if (app_id > 0) { | ||
| count = ns.partition_count(app_id) - ns.primary_count(app_id); | ||
| } else { | ||
| count = ns.partition_count() - ns.primary_count(); |
There was a problem hiding this comment.
Suggested change
| count = ns.partition_count() - ns.primary_count(); | |
| count = app_id > 0 : ns.partition_count(app_id) - ns.primary_count(app_id) : ns.partition_count() - ns.primary_count(); |
There was a problem hiding this comment.
It's too complex to use ternary expression. I don't think it's a good idea
| return (uint32_t)count; | ||
| } | ||
|
|
||
| uint32_t get_skew(const std::map<rpc_address, uint32_t> &count_map) |
There was a problem hiding this comment.
get_diff or get_range?
There was a problem hiding this comment.
skew is more accurate
| { | ||
| int32_t app_id; | ||
| std::string app_name; | ||
| std::vector<std::map<rpc_address, partition_status::type>> partitions; |
There was a problem hiding this comment.
base your code, vector index means pid?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a function to get info used for cluster load balance