This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: throw exception if reads corrupt data #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
changed the title
levy5307
changed the title
hycdong
reviewed
Jul 23, 2021
|
I think |
levy5307
changed the title
hycdong
approved these changes
Jul 23, 2021
foreverneverer
approved these changes
Jul 23, 2021
Smityz
reviewed
Jul 23, 2021
| @@ -39,21 +40,27 @@ class binary_reader | |||
| int read(/*out*/ bool &val) { return read_pod(val); } | |||
|
|
|||
| int read(/*out*/ std::string &s); | |||
| int read(char *buffer, int sz); | |||
| virtual int read(char *buffer, int sz); | |||
There was a problem hiding this comment.
It's an important path on write, add a virtual function will add a performance cost in c++, is this change necessary？
There was a problem hiding this comment.
The performance cost introduced by vtable can be negligible. And this pull request is used for dealing with dirty mutation log.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation, server will coredump if it reads corrupt data.
In this pull request, I changed the way to throw exception. So someone can catch the exception if he don't want to make server crash.