This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: add balance type for cluster load balance #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
changed the title
hycdong
previously approved these changes
Jul 21, 2021
levy5307
changed the title
levy5307
commented
Jul 21, 2021
Smityz
reviewed
Jul 23, 2021
| bool greedy_load_balancer::cluster_replica_balance(const cluster_balance_type type) | ||
| { | ||
| bool enough_information = do_cluster_replica_balance(type); | ||
| if (!enough_information) { |
There was a problem hiding this comment.
It's better to add a log here
There was a problem hiding this comment.
OK. I will add it in later pull requests.
hycdong
reviewed
Jul 26, 2021
foreverneverer
approved these changes
Jul 27, 2021
hycdong
approved these changes
Jul 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement move replicas for cluster load balance