-
Notifications
You must be signed in to change notification settings - Fork 59
fix: fix replica::init_table_level_latency_counter metric name error #830
Conversation
Your code is not formatted. Please run clang-format-3.9 via |
it's ok,now. @neverchanje |
please check this pr,thanks @neverchanje |
Sorry for late response. Since I've been busy dealing with my personal issues these days, I didn't have the time to check and test if your modication works. Would you pls add some tests result in the desctiption? I will do some testing too later today. |
I tested it and found that the output is same whether using |
But when I use task_code(code), the output is _internal_code. Do you know why? |
I have no idea, maybe some convertions happened in the
And it turned out the output is the same in both ways:
|
@lidingshengHHU Thanks for your pull request. Merged |
We should use taskcode(code).to_string() to get metric name , not taskcode(code) to get _internal_code.