Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: add /version http api #824

Merged
merged 16 commits into from
Apr 25, 2021
Merged

fix: add /version http api #824

merged 16 commits into from
Apr 25, 2021

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Apr 22, 2021 •
edited
Loading

Add a interface in builtin_http_calls.h, to show version of pegasus

[12:18:14] smilencer@smilencer-OptiPlex-7040 ~/Code/incubator-pegasus/rdsn (fix-version)$ curl http://meta_ip_port/version
{"Version":"2.1.SNAPSHOT","GitCommit":"88783e1ec28c326974f808d91c1531391d38acb5"}
[12:18:15] smilencer@smilencer-OptiPlex-7040 ~/Code/incubator-pegasus/rdsn (fix-version)$ curl http://replica_ip_port/version
{"Version":"2.1.SNAPSHOT","GitCommit":"88783e1ec28c326974f808d91c1531391d38acb5"}

This interface is existed in the previous version but deleted in 6d4f9c4

@Smityz Smityz changed the title Fix version fix: add /version interface in http_server Apr 23, 2021
@Smityz Smityz changed the title fix: add /version interface in http_server fix: add "meta_server_ip_port/version" interface in http_server Apr 23, 2021
@neverchanje neverchanje changed the title fix: add "meta_server_ip_port/version" interface in http_server fix: add /version http api Apr 23, 2021
@neverchanje
Copy link
Contributor

https://github.com/XiaoMi/rdsn/blob/v2.1/src/replica/replication_service_app.cpp#L66

We also need /version to be added to ReplicaServer. Please refer to this PR https://github.com/XiaoMi/rdsn/pull/615/files. Revert the changes made by it.

tangyanzhao added 2 commits April 25, 2021 12:15
@neverchanje neverchanje merged commit ad9d61d into XiaoMi:master Apr 25, 2021
neverchanje pushed a commit that referenced this pull request Apr 25, 2021
@Smityz @neverchanje
fix: add /version http api (#824)
2c6f215
@hycdong hycdong mentioned this pull request Jun 8, 2021
Closed
@hycdong hycdong added the 2.2.0 label Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@neverchanje neverchanje neverchanje approved these changes

Assignees
No one assigned
Labels
2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smityz @neverchanje @levy5307 @hycdong