This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: separate files from replication.thrift #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
changed the title
foreverneverer
previously approved these changes
Feb 23, 2021
hycdong
reviewed
Feb 23, 2021
neverchanje
force-pushed
the
simplekvthrift
branch
from
e8144bc to
b561911
Compare
hycdong
approved these changes
Feb 23, 2021
foreverneverer
approved these changes
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the replication.thrift into multiple files:
The file names are descriptive for their content.
backup.thrift / bulkload.thrift / duplication.thrift / partition_split.thrift include the RPCs for the corresponding feature.
consensus.thrift includes the structs for PacificA protocol.
meta_admin.thrift and replica_admin.thrift include the RPCs that can be called by clients to operate on either MetaServer or ReplicaServer for administrative purposes.
metadata.thrift is for structs that can be used for multiple modules. For example,
replica_configurationare used bybulkload.thriftandconsensus.thrift. They both include "metadata.thrift".