This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(split): message header should not be empty struct #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Jan 15, 2021
| msg->header = {}; // initialize to empty struct | ||
| memset(static_cast<void *>(msg->header), 0, sizeof(message_header)); |
There was a problem hiding this comment.
I don't see the difference between the two statements. Please write a unit-test for copy_message_no_reply
There was a problem hiding this comment.
As we discuss offline, if header is an empty strtuct, it will lead problem in Line195, which is msg->header->body_length = msg->buffers[1].length();.
neverchanje
approved these changes
Jan 15, 2021
acelyc111
approved these changes
Jan 18, 2021
zhangyifan27
pushed a commit
to zhangyifan27/rdsn
that referenced
this pull request
Jan 25, 2021
zhangyifan27
pushed a commit
to zhangyifan27/rdsn
that referenced
this pull request
Jan 26, 2021
zhangyifan27
pushed a commit
to zhangyifan27/rdsn
that referenced
this pull request
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
copy_message_no_replywill be used during partition split when child copy parent's mutation, its header should not be an empty structure.