Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat: add update rocksdb scenario interface #707

Merged
merged 3 commits into from
Dec 26, 2020
Merged

feat: add update rocksdb scenario interface #707

merged 3 commits into from
Dec 26, 2020

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Dec 24, 2020 •
edited by neverchanje
Loading

This pull request adds update rocksdb scenario envs interface for meta server.

http POST http://xxx/meta/app/usage_scenario app_name=usertable scenario=bulk_load

HTTP/1.1 200 OK
Content-Length: 37
Content-Type: text/plain

{
    "error": "ERR_OK", 
    "hint_message": ""
}

@hycdong hycdong marked this pull request as ready for review December 25, 2020 04:21
acelyc111
acelyc111 reviewed Dec 26, 2020
View reviewed changes
src/meta/meta_http_service.cpp
Comment on lines +786 to +790
if (info.app_name.empty()) {
resp.body = "app_name should not be empty";
resp.status_code = http_status_code::bad_request;
return;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many similar code like this, maybe we can use macros to simplify code in future refactor.

@acelyc111 acelyc111 merged commit 00e3d98 into XiaoMi:master Dec 26, 2020
@hycdong hycdong deleted the add_update_scenario branch December 28, 2020 07:46
hycdong added a commit that referenced this pull request Dec 29, 2020
@hycdong
feat: add update rocksdb scenario interface (#707)
186749d
@neverchanje neverchanje mentioned this pull request Mar 1, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@neverchanje neverchanje neverchanje approved these changes

Assignees
No one assigned
Labels
component/bulk-load component/http HTTP/RESTful support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hycdong @neverchanje @acelyc111