This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
feat: add http interface to get all configs #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Dec 23, 2020
src/http/config_http_service.cpp
Outdated
|
||
void list_all_configs(const http_request &req, http_response &resp) | ||
{ | ||
if (req.query_args.size() != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why check query_args
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone may misunderstand the usage of this interface, and maybe he want to add a query arg to get a special config. the check is used for reminding him.
acelyc111
reviewed
Dec 23, 2020
It seems that we just got discriptions of flags. Can we get the value of flags through this interface? |
acelyc111
previously approved these changes
Dec 24, 2020
neverchanje
suggested changes
Dec 25, 2020
neverchanje
previously approved these changes
Dec 29, 2020
hycdong
previously approved these changes
Dec 30, 2020
hycdong
approved these changes
Dec 30, 2020
neverchanje
approved these changes
Dec 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a http interface to get all configs
Manual Test