This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: fix typo and add comments to security #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
previously approved these changes
Dec 22, 2020
neverchanje
force-pushed
the
security
branch
from
18f300b to
f6dbcc9
Compare
| * If this is a sasl server, it gets the name of the corresponding sasl client. | ||
| * But if this is a sasl client, it gets the name of itself | ||
| **/ | ||
| error_s retrive_username(/*out*/ std::string &output); | ||
| error_s retrieve_username(/*out*/ std::string &output); |
There was a problem hiding this comment.
Maybe extract_username is better?
There was a problem hiding this comment.
I don't extract is better. Because extract means 提取. It's not the responsibility of this interface
There was a problem hiding this comment.
or get_username, retrieve is so confusing.
levy5307
approved these changes
Dec 25, 2020
acelyc111
approved these changes
Dec 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.