This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk_load): add query compaction status http interface #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Dec 23, 2020
src/replica/replica.h
Outdated
| @@ -78,6 +78,14 @@ namespace test { | |||
| class test_checker; | |||
| } | |||
|
|
|||
| enum manual_compaction_status | |||
| { | |||
| CompactionFinish = 0, | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
https://google.github.io/styleguide/cppguide.html#Enumerator_Names
It says "Enumerators (for both scoped and unscoped enums) should be named like constants, not like macros. That is, use kEnumName not ENUM_NAME." :(
There was a problem hiding this comment.
That is my mistake, now it is fixed.
neverchanje
reviewed
Dec 25, 2020
neverchanje
previously approved these changes
Dec 25, 2020
Co-authored-by: Wu Tao <[email protected]>
acelyc111
approved these changes
Dec 26, 2020
foreverneverer
approved these changes
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds replica http interface for query app compaction status.