This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk_load): add update compaction envs http interface #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Dec 22, 2020
neverchanje
reviewed
Dec 22, 2020
neverchanje
reviewed
Dec 22, 2020
neverchanje
previously approved these changes
Dec 22, 2020
acelyc111
reviewed
Dec 23, 2020
Comment on lines
+750
to
+751
| std::vector<std::string> keys; | ||
| std::vector<std::string> values; |
There was a problem hiding this comment.
There maybe problems when keys and values' size or order not matched, how about to use std::map ors std::pair?
There was a problem hiding this comment.
In struct configuration_update_app_env_request, key and value is std::vector, so I also use it here, besides, function set_app_envs will check if keys.size is equal to values.size, if keys size is not equal to values size, it will set ERR_INVALID_PARAMETERS in response.
acelyc111
approved these changes
Dec 24, 2020
neverchanje
approved these changes
Dec 25, 2020
zhangyifan27
pushed a commit
to zhangyifan27/rdsn
that referenced
this pull request
Dec 25, 2020
hycdong
added a commit
that referenced
this pull request
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the http interface for meta server to update app_envs of manual_compaction.