This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix: zk compile cflag no warn format errors #689
Merged
+1
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#685 introduces a compilation flag "CFLAGS=-Wno-error=format-overflow" to suppress integer overflow errors of zookeeper-c-client.
"format-overflow" was introduced in gcc-7 https://gcc.gnu.org/gcc-7/changes.html. But lower-version compilers unrecognized with this flag will fail. So I use
CFLAGS=-Wno-error=format
instead. At this time gcc-7 as well as gcc-4.8.2 all pass.