This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(security): make send/recv message allowed when mandatory_auth is false #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
approved these changes
Oct 12, 2020
acelyc111
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation, if message is not in white list and negotiation is not succeed, the message is not allowed to send or receive. But this will produce error when rolling update.
For example: the
enable_authconfiguration of client session is false, and it is true on the server session side. So client session will not do negotiation work with server session. And when the server session receives one message from this client session , it will close this session connection because this message is not in white list and the negotiation is not succeed.In this pr, I make send/recv message allowed when mandatory_auth is false, so the message will be received successully in this situation. This will make our rolling update work to proceed smoothly.