This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(security): fix bug in building cyrus-sasl #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Sep 7, 2020
src/runtime/test/config-test.ini
Outdated
| @@ -133,3 +133,14 @@ run = true | |||
| [uri-resolver.http://localhost:8080] | |||
| factory = partition_resolver_simple | |||
| arguments = 127.0.0.1:8080 | |||
|
|
|||
| [security] | |||
| krb5_keytab = /etc/pegasus_tst-pegasus.keytab | |||
There was a problem hiding this comment.
These files may not exist on test environment, will the test cases fail?
There was a problem hiding this comment.
Yes, these configs is used for init kerberos. Or we should delete this unit test.
By the way, I prefer to delete the unit test
neverchanje
approved these changes
Sep 8, 2020
foreverneverer
approved these changes
Sep 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug in building cyrus-sasl