This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
refactor(http): add http handler without creating http service #615
Merged
neverchanje
merged 8 commits into
XiaoMi:master
from
neverchanje:http-refactoring-server-decouple
Sep 9, 2020
Merged
refactor(http): add http handler without creating http service #615
neverchanje
merged 8 commits into
XiaoMi:master
from
neverchanje:http-refactoring-server-decouple
Sep 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Sep 8, 2020
src/http/http_server.cpp
Outdated
auto call_ptr = dsn::make_unique<http_call>(); | ||
call_ptr->path = std::move(full_path); | ||
http_call &call = *call_ptr; | ||
// register this call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the comment doesn't make sense. Maybe you can remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Any other problems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
hycdong
reviewed
Sep 8, 2020
hycdong
approved these changes
Sep 9, 2020
levy5307
approved these changes
Sep 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem do I solve?
To register an HTTP handler, we previously needed to define an
http_service
subclass before writing the exact handler.As we can see,
http_service
is too heavy to implement a lightweight handler.How do I solve this problem
We can simplify this short type handler by using
register_http_call
, a new API of the library.Remember that we use
register_http_service
to register anhttp_sevice
. I did tohttp_call
likewise.register_http_call
is designed to be a convenience utility that could boost our future development of new HTTP API.Known issue
In this PR I removed
version_http_service
. This http call will be registered during apegasus_service_app
is created. So I will commit another PR for this.