This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(security): close the connection when something is wrong with sever_negotiation #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
approved these changes
Aug 27, 2020
hycdong
reviewed
Aug 28, 2020
| { | ||
| negotiation_response &response = rpc.response(); | ||
| _status = response.status = negotiation_status::type::SASL_AUTH_FAIL; | ||
| response.msg = reason; |
There was a problem hiding this comment.
In previous implementation, there will be error reason. Is it totally useless?
There was a problem hiding this comment.
It is only used for sending a message to client to show why it is failed. I think it is useless
hycdong
approved these changes
Aug 28, 2020
levy5307
added a commit
to levy5307/rdsn
that referenced
this pull request
Dec 21, 2020
… sever_negotiation (XiaoMi#606)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation, when something is wrong in
server_negotiation, it send a message toclient_negotiation, and theclient_negotiationwill close the connection when it receives the message.So I think we can directly close the connection in this case, no need to send a message.