This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(http): replace service/method with simple HTTP path #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Aug 18, 2020
levy5307
reviewed
Aug 18, 2020
acelyc111
reviewed
Aug 20, 2020
… into http-refactoring-server
acelyc111
previously approved these changes
Aug 20, 2020
levy5307
previously approved these changes
Aug 20, 2020
|
@neverchanje CI is failed |
… into http-refactoring-server
acelyc111
approved these changes
Aug 27, 2020
levy5307
approved these changes
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR I replace
http_request::service_methodwith a simple URL path.struct http_request { static error_with<http_request> parse(dsn::message_ex *m); - // http://ip:port/<service>/<method> - std::pair<std::string, std::string> service_method; + std::string path;And I decouple the registration of HTTP calls from
http_servertohttp_call_registry.http_serveris a special RPC server that handles HTTP requests.http_call_registrymanages the HTTP calls.I will in later PR provide a simpler HTTP service API based on
http_call_registry