This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
task: reimplement safe_late_task with future task #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
reviewed
May 17, 2018
| // | ||
| virtual void clear_callback() {} | ||
| virtual void clear_non_trivial_on_task_end() {} |
There was a problem hiding this comment.
名字有点长，直接 clear_on_task_end() 呢？
include/dsn/tool-api/future_types.h
Outdated
|
|
||
| typedef std::function<void(dsn::error_code)> err_callback; | ||
| typedef future_task<dsn::error_code> error_code_future; | ||
| typedef dsn::ref_ptr<error_code_future> error_code_future_ptr; |
neverchanje
reviewed
May 17, 2018
| @@ -234,13 +236,14 @@ dsn::task_ptr fds_service::create_file(const create_file_request &req, | |||
| const create_file_callback &cb, | |||
| dsn::task_tracker *tracker = nullptr) | |||
| { | |||
| dsn::task_ptr t = dsn::tasking::create_late_task(code, cb, 0, tracker); | |||
| create_file_future_ptr t(new create_file_future(code, cb, 0)); | |||
There was a problem hiding this comment.
能不能设计成
auto t = tasking::create_future<create_file_future>(code, cb, tracker)
对比
create_file_future_ptr t(new create_file_future(code, cb, 0));
t->set_tracker(tracker);
qinzuoyan
approved these changes
May 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.