This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk-load): bulk load download part4 - replica report download status and progress #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
changed the title
neverchanje
previously approved these changes
May 28, 2020
levy5307
reviewed
May 28, 2020
acelyc111
reviewed
May 28, 2020
| } | ||
|
|
||
| total_progress /= _replica->_primary_states.membership.max_replica_count; | ||
| ddebug_replica("total download progress = {}%", total_progress); |
There was a problem hiding this comment.
total_progress will report to meta server in bulk_load_response, defined in thrift, it seems that we don't use float in thrift before, and I think it is okay to define it as integer.
Comment on lines
+502
to
+505
| case bulk_load_status::BLS_DOWNLOADING: | ||
| case bulk_load_status::BLS_DOWNLOADED: | ||
| bulk_load_state.__set_download_progress(_download_progress.load()); | ||
| bulk_load_state.__set_download_status(_download_status.load()); |
There was a problem hiding this comment.
We always report the two type of status, so why separate to two types?
There was a problem hiding this comment.
Do you mean that why not combine download progress and status into one structure? I used to define a structure called download_states before, but I finally separate it, it will make code more complex, besides, download_progress and download_status is more clearer than download_states.
acelyc111
approved these changes
May 29, 2020
neverchanje
approved these changes
May 29, 2020
hycdong
added a commit
to hycdong/rdsn
that referenced
this pull request
May 29, 2020
…load status and progress XiaoMi#479
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole bulk load download process is like:
This pull request is about replica report download status and progress, step 6 and step 7 above.