Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: use reference instead of value #476

Merged
merged 2 commits into from
May 25, 2020
Merged

fix: use reference instead of value #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73524bc
fix
May 25, 2020
94d5ba7
Merge branch 'master' into fix-response
May 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dist/replication/lib/replica_split.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ void replica::child_notify_catch_up() // on child partition
rpc.call(_config.primary,
tracker(),
[this, rpc](error_code ec) mutable {
auto response = rpc.response();
const auto &response = rpc.response();
if (ec == ERR_TIMEOUT) {
dwarn_replica("notify primary catch up timeout, please wait and retry");
tasking::enqueue(LPC_PARTITION_SPLIT,
Expand Down
3 changes: 1 addition & 2 deletions src/dist/replication/meta_server/meta_bulk_load_service.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,7 @@ void bulk_load_service::create_partition_bulk_load_dir(const std::string &app_na
if (--_apps_in_progress_count[pid.get_app_id()] == 0) {
ddebug_f("app({}) start bulk load succeed", app_name);
_apps_in_progress_count[pid.get_app_id()] = partition_count;
auto response = rpc.response();
response.err = ERR_OK;
rpc.response().err = ERR_OK;
}
}
// start send bulk load to replica servers
Expand Down