This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(backup): make backup clear decoupled from on_cold_backup #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
March 24, 2020 15:46
acelyc111
reviewed
Apr 1, 2020
hycdong
reviewed
Apr 2, 2020
added 2 commits
April 2, 2020 15:27
hycdong
previously approved these changes
Apr 3, 2020
acelyc111
reviewed
Apr 5, 2020
Co-Authored-By: Yingchun Lai <[email protected]>
Co-Authored-By: Yingchun Lai <[email protected]>
acelyc111
approved these changes
Apr 7, 2020
hycdong
approved these changes
Apr 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we use the same rpc(RPC_COLD_BACKUP) between clear backup and start backup, which use backup_id = 0 to represent clear backup. But it will lead to messy code.