Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat(dup): rename change_dup_status to modify_dup #423

Merged
merged 2 commits into from
Mar 23, 2020

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Mar 22, 2020

This PR renames "change_dup_status" to "modify_dup".

I need an API to dynamically change some behavior of the duplication, like "app_env" changing the behavior of an app. Since an app may have multiple duplications, this feature cannot be implemented by "app_env".

So I want to reuse the "change_dup_status" API that not only "status" can be changed, but also the new attribute. "modify_dup" is surely more extensible:

struct duplication_modify_request
{
    1:string                    app_name;
    2:i32                       dupid;

    // status is optional. Because modification of a dup may leave the status unchanged.
    3:optional duplication_status status;

    /// new attribute
    4:optional bool xxx.
}

@acelyc111 acelyc111 merged commit e8b02b1 into XiaoMi:master Mar 23, 2020
@neverchanje neverchanje deleted the dup-modify branch March 23, 2020 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants