This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(dup): rename change_dup_status to modify_dup #423
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames "change_dup_status" to "modify_dup".
I need an API to dynamically change some behavior of the duplication, like "app_env" changing the behavior of an app. Since an app may have multiple duplications, this feature cannot be implemented by "app_env".
So I want to reuse the "change_dup_status" API that not only "status" can be changed, but also the new attribute. "modify_dup" is surely more extensible: