Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: weak constraint of ipv4 and incorrect code logic in hostname_from_ip #406

Merged
merged 41 commits into from
Feb 28, 2020
Merged

fix: weak constraint of ipv4 and incorrect code logic in hostname_from_ip #406

merged 41 commits into from
Feb 28, 2020

Conversation

Smityz
Copy link
Contributor

@Smityz Smityz commented Feb 25, 2020

Ref #405

@Smityz Smityz changed the title Fixbug fix: weak constraint of ipv4 and incorrect code logic in hostname_from_ip Feb 25, 2020
vagetablechicken
vagetablechicken suggested changes Feb 25, 2020
View reviewed changes
include/dsn/tool-api/rpc_address.h Outdated Show resolved Hide resolved
src/core/tests/hostname_test.cpp Show resolved Hide resolved
唐彦昭 added 3 commits February 25, 2020 14:28
唐彦昭 added 2 commits February 25, 2020 15:18
唐彦昭 added 3 commits February 25, 2020 16:48
vagetablechicken
vagetablechicken previously approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@vagetablechicken vagetablechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

唐彦昭 added 3 commits February 27, 2020 15:42
唐彦昭 added 2 commits February 27, 2020 17:49
neverchanje
neverchanje suggested changes Feb 28, 2020
View reviewed changes
include/dsn/tool-api/rpc_address.h Outdated Show resolved Hide resolved
src/core/tests/hostname_test.cpp Outdated Show resolved Hide resolved
src/core/tests/hostname_test.cpp Outdated Show resolved Hide resolved
@neverchanje
Copy link
Contributor

The better way to construct ipv4 address is using boost::ip::address_v4::make_address_v4. I don't think we should write on our own. But certainly, this PR is good for now.

唐彦昭 added 2 commits February 28, 2020 13:23
vagetablechicken
vagetablechicken approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@vagetablechicken vagetablechicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Smityz Smityz merged commit 789faa7 into XiaoMi:master Feb 28, 2020
@weekly-digest weekly-digest bot mentioned this pull request Mar 1, 2020
Closed
@neverchanje neverchanje mentioned this pull request Mar 30, 2020
Closed
neverchanje pushed a commit that referenced this pull request Mar 31, 2020
@Smityz
fix: weak constraint of ipv4 and incorrect code logic in hostname_fro…
6fbf040 
…m_ip (#406)
@Smityz Smityz deleted the fixbug branch June 4, 2020 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@levy5307 levy5307 levy5307 left review comments

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@neverchanje neverchanje neverchanje approved these changes

Assignees
No one assigned
Labels
1.12.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Smityz @neverchanje @levy5307 @vagetablechicken