feat(split): register child partition #391

hycdong · 2020-02-11T03:22:19Z

Simple partition split process

meta receives client partition split request, and change partition count split: meta start partition split #286
replica notices partition count changed during on_config_sync
parent partition create child partition split: parent replica create child replica #291
parent prepare states for child to learn feat(split): parent replica prepare states #299
child partition async learn states from parent feat(split): child replica learn parent prepare list and checkpoint #309 feat(split): child replica apply private logs, in-memory mutations and catch up parent #319
child notify parent catch up feat(split): child notify parent catch up #390
update child group partition count
register child partition
parent update group partition count and recover read and write

More partition split discussion in issue #69 and partition split design doc
This pr solves the part of fifth step of partition split, which is bold in process description.

What this pr solved

replica::register_child_on_meta: primary parent register child partition on meta_server and parent will reject read write client.
meta_split_service::register_child_on_meta: meta server update child partition_configuration structure on remote storage and local.
child_partition_active: when child registered, child of primary parent will be the primary of the child replica group, its status will turn from PS_PARTITION_SPLIT to PS_PRIMARY, child of secondary will update its status by group_check.

src/dist/replication/lib/replica_split.cpp

src/dist/replication/meta_server/meta_split_service.cpp

src/dist/replication/lib/replica_split.cpp

src/dist/replication/meta_server/meta_split_service.cpp

src/dist/replication/meta_server/meta_service.cpp

src/dist/replication/lib/replica_split.cpp

neverchanje · 2020-04-16T10:49:26Z

src/dist/replication/lib/replica_split.cpp

+    }
+
+    if (err == ERR_OK) {


Suggested change

}

if (err == ERR_OK) {

} else {

L752-L759 will always be executed, you can see comments in L751

I see no comment:

rdsn/src/dist/replication/lib/replica_split.cpp

Lines 749 to 755 in 14210e2

// ThreadPool: THREAD_POOL_REPLICATION

void replica::child_partition_active(const partition_configuration &config) // on child

{

ddebug_replica("child partition become active");

_primary_states.last_prepare_decree_on_new_primary = _prepare_list->max_decree();

update_configuration(config);

}

The line number changed after I wrote this comment.

rdsn/src/dist/replication/lib/replica_split.cpp

Lines 737 to 738 in 14210e2

// parent register child succeed or child partition has already resgitered

// in both situation, we should reset resgiter child task and child_gpid

src/dist/replication/meta_server/meta_split_service.cpp

neverchanje · 2020-04-16T11:25:11Z

src/dist/replication/meta_server/meta_split_service.cpp

+    const std::string &partition_path = _state->get_partition_path(request.child_config.pid);
+    blob value = dsn::json::json_forwarder<partition_configuration>::encode(request.child_config);
+    if (create_new) {
+        return _meta_svc->get_remote_storage()->create_node(


use get_meta_storage() instead, which can auto-repeat on timeout, and assert on unexpected error.

I tried to use get_meta_storage(), but I should handle ERR_TIMEOUT and ERR_NODE_ALREADY_EXIST specifically in callback function.

OK. I will later write a utility of meta_storage for this case.

src/dist/replication/meta_server/meta_split_service.cpp

src/dist/replication/meta_server/meta_split_service.h

neverchanje · 2020-04-17T02:10:31Z

src/dist/replication/test/meta_test/unit_test/meta_split_service_test.cpp

+        register_child_rpc rpc(std::move(request), RPC_CM_REGISTER_CHILD_REPLICA);
+        split_svc().register_child_on_meta(rpc);
+        wait_all();
+        if (wait_zk) {


what's wait_zk used for? wait_all supposed to wait any tasks to complete.

wait_all function will wait meta_service tasks, zk tasks are not included. The simple way is to sleep for several seconds to wait updating zk succeed.

neverchanje · 2020-04-22T08:54:25Z

src/dist/replication/lib/replica_config.cpp

@@ -369,6 +370,8 @@ void replica::update_configuration_on_meta_server(config_type::type type,
                "");
        dassert(
            newConfig.primary == node, "%s VS %s", newConfig.primary.to_string(), node.to_string());
+    } else if (type == config_type::CT_REGISTER_CHILD) {


Let me describe this code in pseudocode:

If the type is not CT_PRIMARY_FORCE_UPDATE_BALLOT, then it cannot be CT_REGISTER_CHILD.

What does it suppose to mean? Can you add a comment here? Is that CT_REGISTER_CHILD is impossible, or not-CT_PRIMARY_FORCE_UPDATE_BALLOT && CT_REGISTER_CHILD is impossible?

There is no relationship between CT_PRIMARY_FORCE_UPDATE_BALLOT and CT_REGISTER_CHILD. I have updated the code.

neverchanje · 2020-04-22T10:02:35Z

src/dist/replication/lib/replica_split.cpp

+    }
+
+    if (err == ERR_OK) {


I see no comment:

rdsn/src/dist/replication/lib/replica_split.cpp

Lines 749 to 755 in 14210e2

// ThreadPool: THREAD_POOL_REPLICATION

void replica::child_partition_active(const partition_configuration &config) // on child

{

ddebug_replica("child partition become active");

_primary_states.last_prepare_decree_on_new_primary = _prepare_list->max_decree();

update_configuration(config);

}

neverchanje · 2020-04-22T10:08:45Z

src/dist/replication/meta_server/meta_split_service.cpp

+    const std::string &partition_path = _state->get_partition_path(request.child_config.pid);
+    blob value = dsn::json::json_forwarder<partition_configuration>::encode(request.child_config);
+    if (create_new) {
+        return _meta_svc->get_remote_storage()->create_node(


OK. I will later write a utility of meta_storage for this case.

src/dist/replication/lib/replica_config.cpp

hycdong and others added 11 commits February 10, 2020 10:07

add register thrift structure

cbfb985

add code

a4e0ff1

format code and fix bug

5f817e9

add replica unit test

98a1e7b

add meta unit test

7e614b5

fix ut bug and format code

91b3065

add help_function parent_send_register_request

fa06888

small fix

9ce2786

add meta function

f397200

fix

717b5b2

add check while update_configuration

4486f35

hycdong mentioned this pull request Feb 14, 2020

feat(split): update group partition count #392

Closed

weekly-digest bot mentioned this pull request Feb 16, 2020

Weekly Digest (9 February, 2020 - 16 February, 2020) #400

Closed

hycdong added 2 commits March 20, 2020 11:33

merge master

7e50761

refactor code

d4e73e4

hycdong marked this pull request as ready for review March 20, 2020 07:58

hycdong changed the title ~~feat(split): register child partition [WIP]~~ feat(split): register child partition Mar 20, 2020

hycdong added the component/split label Mar 20, 2020

hycdong and others added 4 commits March 23, 2020 10:50

Merge branch 'master' into register_child

77a839a

Merge branch 'master' into register_child

a8a0540

Merge branch 'master' into register_child

06f84da

Merge branch 'master' into register_child

08f8988

levy5307 reviewed Apr 10, 2020

View reviewed changes

src/dist/replication/lib/replica_split.cpp Outdated Show resolved Hide resolved

levy5307 reviewed Apr 10, 2020

View reviewed changes

src/dist/replication/lib/replica_split.cpp Outdated Show resolved Hide resolved

levy5307 reviewed Apr 10, 2020

View reviewed changes

src/dist/replication/meta_server/meta_split_service.cpp Outdated Show resolved Hide resolved

levy5307 reviewed Apr 10, 2020

View reviewed changes

src/dist/replication/meta_server/meta_split_service.cpp Outdated Show resolved Hide resolved

Merge branch 'master' into register_child

ea17bcb

acelyc111 reviewed Apr 12, 2020

View reviewed changes

hycdong and others added 2 commits April 13, 2020 13:43

fix by review

2c5208e

Merge branch 'master' into register_child

f33a9fa

acelyc111 previously approved these changes Apr 16, 2020

View reviewed changes

Merge branch 'master' into register_child

8604345

neverchanje reviewed Apr 17, 2020

View reviewed changes

update by review and add unit test

14210e2

hycdong dismissed acelyc111’s stale review via 14210e2 April 17, 2020 07:59

neverchanje reviewed Apr 22, 2020

View reviewed changes

fix by review

8e34c68

neverchanje reviewed Apr 24, 2020

View reviewed changes

src/dist/replication/lib/replica_config.cpp Outdated Show resolved Hide resolved

hycdong and others added 3 commits April 24, 2020 11:43

Merge branch 'master' into register_child

a132eba

small fix

1f0fd93

Merge branch 'master' into register_child

79d9e5d

acelyc111 approved these changes Apr 24, 2020

View reviewed changes

neverchanje approved these changes Apr 24, 2020

View reviewed changes

neverchanje merged commit bfabb1c into XiaoMi:master Apr 24, 2020

hycdong deleted the register_child branch May 9, 2020 07:16

neverchanje mentioned this pull request May 14, 2020

Release 2.0.0 apache/incubator-pegasus#536

Closed

neverchanje added the 2.0.0 label Jun 5, 2020

neverchanje mentioned this pull request Jun 10, 2020

Release 1.12.4 apache/incubator-pegasus#547

Closed

hycdong added a commit to hycdong/rdsn that referenced this pull request Jun 24, 2020

merge feat(split): register child partition XiaoMi#391

8157d69

This was referenced Oct 15, 2020

feat(split): implement child_handle_split_error #642

Merged

feat(split): add update_child_group_partition_count #645

Merged

This was referenced Oct 28, 2020

feat(split): add splitting_replicas while on_config_sync #653

Merged

feat(split): parent group update partition count #654

Merged

hycdong mentioned this pull request Nov 26, 2020

feat(split): secondary start split #675

Merged

hycdong mentioned this pull request Feb 2, 2021

feat(split): replica add validate_partition_hash #747

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(split): register child partition #391

feat(split): register child partition #391

hycdong commented Feb 11, 2020 •

edited

Loading

neverchanje Apr 16, 2020

hycdong Apr 17, 2020 •

edited

Loading

neverchanje Apr 22, 2020

hycdong Apr 23, 2020

neverchanje Apr 16, 2020

hycdong Apr 17, 2020

neverchanje Apr 22, 2020

neverchanje Apr 17, 2020

hycdong Apr 17, 2020 •

edited

Loading

neverchanje Apr 22, 2020

hycdong Apr 23, 2020

neverchanje Apr 22, 2020

neverchanje Apr 22, 2020

	// ThreadPool: THREAD_POOL_REPLICATION
	void replica::child_partition_active(const partition_configuration &config) // on child
	{
	ddebug_replica("child partition become active");
	_primary_states.last_prepare_decree_on_new_primary = _prepare_list->max_decree();
	update_configuration(config);
	}

	// parent register child succeed or child partition has already resgitered
	// in both situation, we should reset resgiter child task and child_gpid

feat(split): register child partition #391

feat(split): register child partition #391

Conversation

hycdong commented Feb 11, 2020 • edited Loading

Simple partition split process

What this pr solved

Choose a reason for hiding this comment

hycdong Apr 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hycdong Apr 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hycdong commented Feb 11, 2020 •

edited

Loading

hycdong Apr 17, 2020 •

edited

Loading

hycdong Apr 17, 2020 •

edited

Loading