Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

refactor(network): refine codes and comments #380

Merged
merged 4 commits into from
Jan 19, 2020
Merged

refactor(network): refine codes and comments #380

merged 4 commits into from
Jan 19, 2020

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Jan 14, 2020 •
edited
Loading

I found some functions are useless anymore, remove them.

- connection_oriented_network::get_client_session
- rpc_session::is_disconnected
- rpc_session::is_connecting
- rpc_session::is_connected

I further reviewed the codes of connection_oriented_network::check_if_conn_threshold_exceeded, and connection_oriented_network::on_server_session_disconnected. I made some refactoring on comments and variable names to improve readability.

@weekly-digest weekly-digest bot mentioned this pull request Jan 19, 2020
Closed
@acelyc111 acelyc111 merged commit 766edef into XiaoMi:master Jan 19, 2020
@neverchanje neverchanje deleted the networkrefactor branch January 19, 2020 06:51
@weekly-digest weekly-digest bot mentioned this pull request Jan 26, 2020
Closed
@neverchanje neverchanje mentioned this pull request Mar 30, 2020
Closed
neverchanje pushed a commit that referenced this pull request Mar 31, 2020
refactor(network): refine codes and comments (#380)
6039d36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@levy5307 levy5307 levy5307 approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
1.12.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neverchanje @acelyc111 @levy5307