This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: remove useless files (version.h, coredump.win.cpp, ReleaseNote) #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neverchanje
commented
Jan 13, 2020
•
neverchanje
commented
- src/core/core/coredump.win.cpp: the coredump implementation for Windows, we don't support Windows at all, remove it
- include/dsn/version.h: the version of pegasus is determined by pegasus/src/include/version.h, whereas DSN_CORE_VERSION is always 1.0.0, remove it.
- Release Notes.txt: rDSN is only a component of Pegasus, we don't release for it, remove.
neverchanje
force-pushed
the
rmversion
branch
from
f5703ca to
02949d1
Compare
levy5307
approved these changes
Jan 14, 2020
qinzuoyan
approved these changes
Jan 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.