This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: add check for app envs #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Dec 9, 2019
acelyc111
reviewed
Dec 10, 2019
neverchanje
reviewed
Dec 10, 2019
acelyc111
reviewed
Dec 20, 2019
neverchanje
reviewed
Dec 25, 2019
acelyc111
reviewed
Jan 21, 2020
acelyc111
reviewed
Jan 21, 2020
added 2 commits
January 21, 2020 13:57
acelyc111
previously approved these changes
Jan 24, 2020
neverchanje
reviewed
Feb 3, 2020
| return true; | ||
| } | ||
|
|
||
| bool check_write_throttling(const std::string &env_value, std::string &hint_message) |
There was a problem hiding this comment.
你这个跟 throttling_controller::parse_from_env 代码有比较大的重复，meta 检查了参数，replica 实际上就不需要检查了。可以后续的 PR 删。
另外你这个检查其实忽略了一种 case：100K*delay*100,200K*delay*100 这种你会判断是对的，
There was a problem hiding this comment.
你这个跟 throttling_controller::parse_from_env 代码有比较大的重复，meta 检查了参数，replica 实际上就不需要检查了。可以后续的 PR 删。
另外你这个检查其实忽略了一种 case：
100K*delay*100,200K*delay*100这种你会判断是对的，
也不能删，万一meta是老的，replica是新的，replica的判断给删了就没有了检查。你说的那个case的检查也实现了
neverchanje
previously approved these changes
Feb 3, 2020
neverchanje
approved these changes
Feb 4, 2020
acelyc111
approved these changes
Feb 4, 2020
levy5307
changed the title
neverchanje
pushed a commit
that referenced
this pull request
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In meta server, we have no check for app env replica.write_throttling and replica.write_throttling_by_size now, so there is no hint message when user sets an invalid value.