Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: meta unnecessary assert #332

Merged
merged 4 commits into from
Oct 24, 2019
Merged

fix: meta unnecessary assert #332

merged 4 commits into from
Oct 24, 2019

Conversation

foreverneverer
Copy link
Contributor

@neverchanje neverchanje added the type/bug-fix This PR fixes a bug. label Oct 22, 2019
@neverchanje
Copy link
Contributor

@vagetablechicken 你过的太随意了把，这个很明显编译都没通过呀

@foreverneverer
Copy link
Contributor Author

@vagetablechicken 你过的太随意了把，这个很明显编译都没通过呀

她走之前我测试的。我看了一下，我最后commit的本地测试通过后，没提交上来，这个commit不是最新的~

@vagetablechicken
Copy link
Member

@vagetablechicken 你过的太随意了把，这个很明显编译都没通过呀

昨天的问题在build失败，修完就过了啊。
不过今天这个pr travis出现过DDD coredump，没通过，我已经记录下来了，要查问题的。但这个不归这次pr管，而且偶发，也不一定好查。这不travis又过了。。。

@neverchanje neverchanje merged commit 4fd2cbe into XiaoMi:master Oct 24, 2019
@neverchanje neverchanje mentioned this pull request Oct 25, 2019
Closed
@weekly-digest weekly-digest bot mentioned this pull request Oct 27, 2019
Closed
@foreverneverer foreverneverer mentioned this pull request Dec 10, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vagetablechicken vagetablechicken vagetablechicken approved these changes

@hycdong hycdong hycdong approved these changes

Assignees
No one assigned
Labels
type/bug-fix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foreverneverer @neverchanje @vagetablechicken @hycdong