This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: rename disk_aio to aio_context #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
qinzuoyan,
acelyc111,
hycdong and
foreverneverer
foreverneverer
previously approved these changes
Sep 16, 2019
|
是不是改成disk_aio_context更好？ |
|
@hycdong 我们的 RPC 没有 aio 的说法，所以 aio 可以待指 disk aio，名字简单点比较容易使用。 |
acelyc111
reviewed
Sep 16, 2019
| char buffer[128]; | ||
| // in simulator environment this task will be executed immediately, | ||
| // so we excluded config-test-sim.ini for this test. | ||
| auto t = file::read(fp, buffer, 128, 0, LPC_TASK_TEST, nullptr, nullptr); | ||
|
|
||
| t->wait(10000); | ||
| ASSERT_TRUE(t->_wait_event.load() != nullptr); |
There was a problem hiding this comment.
是的 @acelyc111 但是晚修不如早修
acelyc111
previously approved these changes
Sep 16, 2019
qinzuoyan
previously approved these changes
Sep 16, 2019
hycdong
reviewed
Sep 16, 2019
hycdong
reviewed
Sep 16, 2019
hycdong
approved these changes
Sep 16, 2019
acelyc111
approved these changes
Sep 16, 2019
qinzuoyan
approved these changes
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many places,
disk_aiois aliased toxxx_aio_context. For example:posix_disk_aio_contextandlinux_disk_aio_contextdisk_engine::prepare_aio_contextgenerates a new disk_aio object.So make it called
aio_contextsounds more natural thandisk_aio.