This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(split): child replica learn parent prepare list and checkpoint #309
feat(split): child replica learn parent prepare list and checkpoint #309
Changes from all commits
5f1f398
b21fa08
866ff64
3f6e110
8535c61
f10c7ca
99e2ce6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里 sync_checkpoint 是什么原因?必须要 checkpoint 吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里child已经异步learn完成,包括checkpoint, prepare_list, private_log和in-memory mutation,这时打一个checkpoint相当于标识异步learn完成,而且方便接下来的catch up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
”方便接下来的catch up“ 我没有理解主要是哪些方面方便了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在异步learn完成之后,child还需要catch up在它进行异步learn过程中parent的states,这时打一个checkpoint,能把之前异步learn的states durable,更新一下last_durable_decree,主要是这个作用