Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

utils: test format utilities #231

Merged
merged 2 commits into from
Mar 12, 2019
Merged

utils: test format utilities #231

merged 2 commits into from
Mar 12, 2019

Conversation

neverchanje
Copy link
Contributor

@neverchanje neverchanje commented Mar 12, 2019

补充了

std::ostream &operator<<(std::ostream &o, string_view piece)

的实现(拷贝于 abseil),之前 string_view 是不支持 operator<< 的

@@ -0,0 +1,61 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是不是放在 src/dist/replication/test/common_test 下面更好?

Copy link
Contributor Author

@neverchanje neverchanje Mar 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前和伟杰商量了一下,以后测试代码看看都放在相应目录下的 test/ 目录,比如 replica_test 后面会移到 lib 下,这样比较清晰,方便找

/lib
/lib/test
/common
/common/test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

也行,那后面逐渐移下

qinzuoyan
qinzuoyan previously approved these changes Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants