This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
reviewed
Mar 12, 2019
@@ -0,0 +1,61 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个是不是放在 src/dist/replication/test/common_test 下面更好?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前和伟杰商量了一下,以后测试代码看看都放在相应目录下的 test/ 目录,比如 replica_test 后面会移到 lib 下,这样比较清晰,方便找
/lib
/lib/test
/common
/common/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
也行,那后面逐渐移下
qinzuoyan
previously approved these changes
Mar 12, 2019
neverchanje
requested review from
acelyc111,
hycdong,
mentoswang and
vagetablechicken
March 12, 2019 06:50
qinzuoyan
approved these changes
Mar 12, 2019
acelyc111
approved these changes
Mar 12, 2019
24 tasks
neverchanje
pushed a commit
that referenced
this pull request
Jun 14, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
补充了
std::ostream &operator<<(std::ostream &o, string_view piece)
的实现(拷贝于 abseil),之前 string_view 是不支持 operator<< 的