This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengofsun
reviewed
Sep 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo这个文件夹整体可以都删了。
想看rpc怎么用,还不如直接看cli或者nfs这两个文件夹。
根目录下的tutorial也可以删了,这个"tutorial"除了误导人也发挥不了更多作用了。
总体来看的话,删.types.h,只要编译能过,别的问题应该都不大。
另外这么一改,compile_thrift.py就不能用了。下个pr看着怎么处理thrift编译的问题 |
@shengofsun 我看 bin 里面的 dsn.templates 还有各种 php 不爽很久了,你看看怎么删,能删吗 |
各种templates还有php就是为了生成xxx.server.h, xxx.client.h, xxx.code.definition.h这些东西的。 |
vagetablechicken
approved these changes
Sep 28, 2018
shengofsun
approved these changes
Sep 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.