Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

*: remove *.types.h files #164

Merged
merged 8 commits into from
Sep 28, 2018
Merged

*: remove *.types.h files #164

merged 8 commits into from
Sep 28, 2018

Conversation

neverchanje
Copy link
Contributor

No description provided.

Copy link
Contributor

@shengofsun shengofsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo这个文件夹整体可以都删了。
想看rpc怎么用,还不如直接看cli或者nfs这两个文件夹。
根目录下的tutorial也可以删了,这个"tutorial"除了误导人也发挥不了更多作用了。

总体来看的话,删.types.h,只要编译能过,别的问题应该都不大。

@shengofsun
Copy link
Contributor

另外这么一改,compile_thrift.py就不能用了。下个pr看着怎么处理thrift编译的问题

@neverchanje
Copy link
Contributor Author

@shengofsun 我看 bin 里面的 dsn.templates 还有各种 php 不爽很久了,你看看怎么删,能删吗

@shengofsun
Copy link
Contributor

各种templates还有php就是为了生成xxx.server.h, xxx.client.h, xxx.code.definition.h这些东西的。
如果删了他们,我们就得手动维护这些东西。
不过现在看来还好,现在service已经非常少了,而且最大头的replication已经是手动维护了。
后面需要,可以用python来简单糊一个。删掉问题不到。

@neverchanje neverchanje merged commit ca2b88e into XiaoMi:master Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants