This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
clientlet: remove class clientlet, add new class thread_access_checker #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: include/dsn/cpp/serverlet.h include/dsn/service_api_cpp.h include/dsn/tool/cli/cli.client.h src/core/tests/async_call.cpp src/core/tests/rpc.cpp src/dist/replication/lib/replica.h src/dist/replication/lib/replica_chkpt.cpp src/dist/replication/lib/replica_stub.cpp src/dist/replication/zookeeper/lock_types.h
acelyc111
reviewed
Jul 12, 2018
| #include <cstdlib> | ||
| #include <sys/stat.h> | ||
| #include <dsn/utility/filesystem.h> | ||
| #include <dsn/tool-api/async_calls.h> | ||
|
|
||
| #include "nfs_server_impl.h" |
There was a problem hiding this comment.
| #include <dsn/service_api_cpp.h> | ||
| #include <dsn/cpp/clientlet.h> | ||
|
|
||
| #include <gtest/gtest.h> |
| EXPECT_TRUE(t != nullptr); | ||
| t->wait(); | ||
| EXPECT_TRUE(cl->str == "after called"); | ||
| delete cl; | ||
| EXPECT_TRUE(tc->str == "after called"); |
There was a problem hiding this comment.
改到这里了，就把EXPECT_TRUE改成EXPECT_EQ/NE吧，这个文件里的其他几处也是
还有为什么不是ASSERT_*呢？
| #include "test_utils.h" | ||
|
|
||
| DEFINE_TASK_CODE(LPC_TEST_CLIENTLET, TASK_PRIORITY_COMMON, THREAD_POOL_TEST_SERVER) | ||
| using namespace dsn; | ||
|
|
||
| int global_value; | ||
| class test_clientlet : public clientlet | ||
| class tracker_class |
qinzuoyan
approved these changes
Jul 12, 2018
acelyc111
approved these changes
Jul 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing class clientlet & file "clientlet.h" coz it's hard to describe what "clientlet" is when writing documents or comments.
So the "clientlet.h" is seperated into two modules: