This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
rpc_session: do some refactor #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shengofsun
commented
Jun 29, 2018
shengofsun
commented
- adjust name and position of some functions in rpc session
- rename "close_on_fault_injection" to more general "close"
- delete a useless function
1. adjust name and position of some functions in rpc session 2. rename "close_on_fault_injection" to more general "close" 3. delete a useless function
qinzuoyan
previously approved these changes
Jul 2, 2018
LoveHeat
reviewed
Jul 2, 2018
include/dsn/tool-api/network.h
Outdated
| DSN_API bool unlink_message_for_send(); | ||
| DSN_API void clear_send_queue(bool resend_msgs); | ||
| // return whether there are messages for sending; | ||
| // should always be called in lock |
There was a problem hiding this comment.
这个注释是用来注释 unlink_message_for_send()函数的吧？
LoveHeat
reviewed
Jul 2, 2018
include/dsn/tool-api/network.h
Outdated
| // buffer is prepared well in _sending_buffers | ||
| // always call on_send_completed later | ||
| // | ||
| public: |
LoveHeat
approved these changes
Jul 2, 2018
qinzuoyan
approved these changes
Jul 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.