Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix: assert is not necessary when the table config is updated #1121

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Jun 16, 2022

Related-Issue

apache/incubator-pegasus#903.

Change

c++ client will crush for assert if server table config is changed, for example, remove table and re-build same name table.
But it's not necessary because config-update will trigger the client fetch latest right config, which don't has any problem.

I found the problem is that the duplication module use the c++ client code: if one duplication failed, I want drop the remote table and re-start new duplication task, but it will result that all the master replica crush for the remote table config changing

So please must merge this pr when release duplication(apache/incubator-pegasus#892)

@acelyc111
Copy link
Member

If the duplication is in progress, then drop the dest table and create a new one, how will the duplication act now? restart the duplication or keep in progress?

@foreverneverer
Copy link
Contributor Author

foreverneverer commented Jun 17, 2022

If the duplication is in progress, then drop the dest table and create a new one, how will the duplication act now? restart the duplication or keep in progress?

  • In DS_LOG, it will keep sending plog
  • In DS_APP , it will failed(before the pr, it will crush) and you have to remove the duplication and re-create new duplication
  • In DS_START, if remote-cluster has exist same name table, it will block and report exist error, and auto-create new one after you drop it

@foreverneverer foreverneverer merged commit c563079 into XiaoMi:master Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants