This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix: assert is not necessary when the table config is updated #1121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related-Issue
apache/incubator-pegasus#903.
Change
c++ client will crush for
assert
if server table config is changed, for example, remove table and re-build same name table.But it's not necessary because
config-update
will trigger the client fetchlatest right config
, which don't has any problem.I found the problem is that the
duplication module
use the c++ client code: if one duplication failed, I want drop the remote table and re-start new duplication task, but it will result that all the master replica crush for the remote table config changingSo please must merge this pr when release
duplication
(apache/incubator-pegasus#892)