fix

XiaoMi · Mar 8, 2021 · a56e055 · a56e055
1 parent 04c8d24
commit a56e055
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/common/backup.thrift b/src/common/backup.thrift
@@ -163,6 +163,10 @@ struct start_backup_app_request
 
 struct start_backup_app_response
 {
+    // Possible error:
+    // - ERR_INVALID_STATE: app is not available or is backing up
+    // - ERR_INVALID_PARAMETERS: backup provider type is invalid
+    // - ERR_SERVICE_NOT_ACTIVE: meta doesn't enable backup service
     1:dsn.error_code    err;
     2:string            hint_message;
 }
diff --git a/src/meta/backup_engine.cpp b/src/meta/backup_engine.cpp
@@ -74,7 +74,7 @@ error_code backup_engine::set_block_service(const std::string &provider)
     return ERR_OK;
 }
 
-error_code backup_engine::run() { return ERR_OK; }
+error_code backup_engine::start() { return ERR_OK; }
 
 bool backup_engine::is_backing_up()
 {

diff --git a/src/meta/backup_engine.h b/src/meta/backup_engine.h
@@ -58,11 +58,11 @@ class backup_engine
     error_code init_backup(int32_t app_id);
     error_code set_block_service(const std::string &provider);
 
-    error_code run();
+    error_code start();
 
     int64_t get_current_backup_id() const { return _cur_backup.backup_id; }
     int32_t get_backup_app_id() const { return _cur_backup.app_id; }
-    bool is_backing_up() const;
+    bool is_backing_up();
 
 private:
     error_code get_app_stat(int32_t app_id, std::shared_ptr<app_state> &app);