fix: use reference instead of value (#476)

XiaoMi · May 25, 2020 · 5aabc57 · 5aabc57
1 parent 4ebbd1b
commit 5aabc57
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/dist/replication/lib/replica_split.cpp b/src/dist/replication/lib/replica_split.cpp
@@ -492,7 +492,7 @@ void replica::child_notify_catch_up() // on child partition
     rpc.call(_config.primary,
              tracker(),
              [this, rpc](error_code ec) mutable {
-                 auto response = rpc.response();
+                 const auto &response = rpc.response();
                  if (ec == ERR_TIMEOUT) {
                      dwarn_replica("notify primary catch up timeout, please wait and retry");
                      tasking::enqueue(LPC_PARTITION_SPLIT,

diff --git a/src/dist/replication/meta_server/meta_bulk_load_service.cpp b/src/dist/replication/meta_server/meta_bulk_load_service.cpp
@@ -241,8 +241,7 @@ void bulk_load_service::create_partition_bulk_load_dir(const std::string &app_na
                 if (--_apps_in_progress_count[pid.get_app_id()] == 0) {
                     ddebug_f("app({}) start bulk load succeed", app_name);
                     _apps_in_progress_count[pid.get_app_id()] = partition_count;
-                    auto response = rpc.response();
-                    response.err = ERR_OK;
+                    rpc.response().err = ERR_OK;
                 }
             }
             // start send bulk load to replica servers