feat(dup): implement is_duplicating (#356)

XiaoMi · Mar 29, 2020 · 46f9760 · 46f9760
1 parent 7ae6178
commit 46f9760
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 47 deletions.
diff --git a/src/dist/replication/lib/duplication/replica_duplicator_manager.cpp b/src/dist/replication/lib/duplication/replica_duplicator_manager.cpp
@@ -117,7 +117,6 @@ void replica_duplicator_manager::update_confirmed_decree_if_secondary(decree con
             _primary_confirmed_decree = confirmed;
         }
     }
-    _replica->update_init_info_duplicating(confirmed >= 0);
 }
 
 } // namespace replication

diff --git a/src/dist/replication/lib/replica.h b/src/dist/replication/lib/replica.h
@@ -170,10 +170,11 @@ class replica : public serverlet<replica>, public ref_counter, public replica_ba
     bool verbose_commit_log() const;
     dsn::task_tracker *tracker() { return &_tracker; }
 
-    /// \see replica_duplicate.cpp
+    //
+    // Duplication
+    //
     replica_duplicator_manager *get_duplication_manager() const { return _duplication_mgr.get(); }
-    bool is_duplicating() const;
-    void update_init_info_duplicating(bool duplicating);
+    bool is_duplicating() const { return _app_info.duplicating; }
 
     void update_last_checkpoint_generate_time();
 

diff --git a/src/dist/replication/lib/replica_duplicate.cpp b/src/dist/replication/lib/replica_duplicate.cpp
-Original file line number
+Diff line change
@@ Expand Up @@
                 _primary_confirmed_decree = confirmed;
             }
         }
-        _replica->update_init_info_duplicating(confirmed >= 0);
     }
     } // namespace replication
@@ Expand Down @@