fix by comment

XiaoMi · Feb 19, 2020 · 2025b91 · 2025b91
1 parent 59fcced
commit 2025b91
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/include/dsn/dist/replication/replication_app_base.h b/include/dsn/dist/replication/replication_app_base.h
@@ -228,6 +228,11 @@ class replication_app_base : public replica_base
     // query app envs.
     virtual void query_app_envs(/*out*/ std::map<std::string, std::string> &envs) = 0;
 
+    // `partition_version` is used to guarantee data consistency during partition split.
+    // In normal cases, partition_version = partition_count-1, when this replica rejects read
+    // and write request, partition_version = -1.
+    //
+    // Thread-safe.
     virtual void set_partition_version(int32_t partition_version) = 0;
 
 public:

diff --git a/src/dist/replication/lib/replica.h b/src/dist/replication/lib/replica.h
@@ -494,8 +494,8 @@ class replica : public serverlet<replica>, public ref_counter, public replica_ba
     // ballot when starting partition split and split will stop if ballot changed
     // _child_init_ballot = 0 if partition not in partition split
     ballot _child_init_ballot{0};
-    // in normal case _partition_version = partition_count-1
-    // when parent register child, _partition_version = -1, will reject client read write request
+    // in normal cases, _partition_version = partition_count-1
+    // when replica reject client read write request, partition_version = -1
     std::atomic<int32_t> _partition_version;
 
     // perf counters