Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

refactor: optimize perf-counter #98

Merged

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Apr 3, 2020

The perf-counter has some problem:

  • Existed many redundant counter, such as *.cps-15min,latency.p50 etc, this pr delete these.
  • No existed suitable tag: user usually don't set the tag config or we don‘t get it though it is set, this pr will add first ip of meta list and table name as default tag which also join to the user tag if it is set. add meta=ip tag is because sometimes different meta_server has same table name, so that if you search table=name , we will not distinguish it. The follow is an tag example:

user tag string: cluster=xiaomi
the final tag : cluster=xiaomi,meta=ip,table=name

  • enable_perf_counter default value is set true

@foreverneverer foreverneverer changed the title feat:optimize perf-counter feat: optimize perf-counter Apr 3, 2020
@acelyc111
Copy link
Member

this pr will add first ip of meta list and table name as default tag which also join to the user tag if it is set.

cluster meta list is mutable, how to deal with the case when meta server changed?

@foreverneverer
Copy link
Contributor Author

foreverneverer commented Apr 7, 2020

this pr will add first ip of meta list and table name as default tag which also join to the user tag if it is set.

cluster meta list is mutable, how to deal with the case when meta server changed?

Yeah, I have considered it. Actually, only table tag is included in different clusters, meta ip may be used when we search. Now, since meta list is not host name, I haven't find a way the same as sever client to add invariable tag for one cluster.

@foreverneverer foreverneverer force-pushed the refactor-perfcounter branch from ec92107 to 487ca97 Compare May 12, 2020 06:52
@foreverneverer foreverneverer changed the title feat: optimize perf-counter refactor: optimize perf-counter May 12, 2020
@foreverneverer
Copy link
Contributor Author

New commit has delete meta ip

neverchanje
neverchanje previously approved these changes May 19, 2020
levy5307
levy5307 previously approved these changes May 19, 2020
acelyc111
acelyc111 previously approved these changes May 25, 2020
acelyc111
acelyc111 previously approved these changes May 25, 2020
@foreverneverer
Copy link
Contributor Author

I will re-test it manually before merged

@foreverneverer foreverneverer dismissed stale reviews from acelyc111 and levy5307 via 1658b44 May 25, 2020 09:05
@foreverneverer foreverneverer force-pushed the refactor-perfcounter branch from 61a9957 to 1658b44 Compare May 28, 2020 02:29
neverchanje
neverchanje previously approved these changes May 28, 2020
@levy5307 levy5307 merged commit 33a9a05 into XiaoMi:thrift-0.11.0-inlined Jun 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants