This repository has been archived by the owner on May 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: optimize perf-counter #98
Merged
levy5307
merged 15 commits into
XiaoMi:thrift-0.11.0-inlined
from
foreverneverer:refactor-perfcounter
Jun 1, 2020
Merged
refactor: optimize perf-counter #98
levy5307
merged 15 commits into
XiaoMi:thrift-0.11.0-inlined
from
foreverneverer:refactor-perfcounter
Jun 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cluster meta list is mutable, how to deal with the case when meta server changed? |
Yeah, I have considered it. Actually, only |
foreverneverer
force-pushed
the
refactor-perfcounter
branch
from
May 12, 2020 06:52
ec92107
to
487ca97
Compare
foreverneverer
changed the title
feat: optimize perf-counter
refactor: optimize perf-counter
May 12, 2020
neverchanje
reviewed
May 15, 2020
src/main/java/com/xiaomi/infra/pegasus/metrics/MetricsPool.java
Outdated
Show resolved
Hide resolved
New commit has delete meta ip |
neverchanje
previously approved these changes
May 19, 2020
…va-client into refactor-perfcounter
levy5307
reviewed
May 19, 2020
src/main/java/com/xiaomi/infra/pegasus/metrics/MetricsPool.java
Outdated
Show resolved
Hide resolved
levy5307
previously approved these changes
May 19, 2020
acelyc111
previously approved these changes
May 25, 2020
acelyc111
previously approved these changes
May 25, 2020
I will re-test it manually before merged |
foreverneverer
commented
May 25, 2020
src/main/java/com/xiaomi/infra/pegasus/rpc/async/ClientRequestRound.java
Show resolved
Hide resolved
levy5307
reviewed
May 25, 2020
src/main/java/com/xiaomi/infra/pegasus/metrics/MetricsPool.java
Outdated
Show resolved
Hide resolved
foreverneverer
force-pushed
the
refactor-perfcounter
branch
from
May 28, 2020 02:29
61a9957
to
1658b44
Compare
neverchanje
previously approved these changes
May 28, 2020
neverchanje
approved these changes
Jun 1, 2020
levy5307
approved these changes
Jun 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The perf-counter has some problem:
*.cps-15min
,latency.p50
etc, this pr delete these.meta=ip
tag is because sometimes different meta_server has same table name, so that if you searchtable=name
, we will not distinguish it. The follow is an tag example:enable_perf_counter
default value is settrue