This repository has been archived by the owner on May 10, 2022. It is now read-only.
fix: use operation_timeout as socket connect timeout #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
changed the title
neverchanje
approved these changes
Nov 19, 2019
foreverneverer
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use operation_timeout as socket connect timeout, instead of Cluster.SOCK_TIMEOUT.
This fixes the problem that the client may request a disconnected replica-server when the session was unable to establish in
SOCKET_TIMEOUT(aka 1 second), and finally getsERR_SESSION_RESETerror, even though itsoperationTimeoutis 10 seconds.This is user-unfriendly and counterintuitive because the user actually allows 10 seconds to wait, but the request didn't utilize the sufficient time budget.